skia/skia.gyp - Issue 10830199: Working around quoting in GR_GL_CUSTOM_SETUP_HEADER fix VS2008 builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/skia.gyp

Issue 10830199: Working around quoting in GR_GL_CUSTOM_SETUP_HEADER fix VS2008 builder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/skia.gyp

diff --git a/skia/skia.gyp b/skia/skia.gyp

index 7ddd006c29601619a6910c9099a7dce35338c3fb..f67ce60986bfda315312e4cd914484eb1309b35c 100644

--- a/skia/skia.gyp

+++ b/skia/skia.gyp

@@ -823,7 +823,9 @@

'SK_GAMMA_SRGB',

#'SK_GAMMA_APPLY_TO_A8',

'SK_BUILD_NO_IMAGE_ENCODE',

- 'GR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"',

+ # TODO(alexeypa): fix quoting in the skia sources,

+ # see http://crbug.com/141132.

+ 'GR_GL_CUSTOM_SETUP_HEADER=<GrGLConfig_chrome.h>',

'GR_STATIC_RECT_VB=1',

'GR_AGGRESSIVE_SHADER_OPTS=1',

'SK_DISABLE_FAST_AA_STROKE_RECT',

@@ -1107,7 +1109,9 @@

'defines': [

'SK_BUILD_NO_IMAGE_ENCODE',

'SK_DEFERRED_CANVAS_USES_GPIPE=1',

- 'GR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"',

+ # TODO(alexeypa): fix quoting in the skia sources,

+ # see http://crbug.com/141132.

+ 'GR_GL_CUSTOM_SETUP_HEADER=<GrGLConfig_chrome.h>',

'GR_AGGRESSIVE_SHADER_OPTS=1',

'conditions': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »