Decreased spacing for "name" label above name input box in create/manage dialog

Decreased spacing for "name" label above name input box in create/manage dialog

BUG=141127
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150370

[James Hawkins, 2012-08-07 01:26:34]

http://codereview.chromium.org/10830194/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/manage_profile_overlay.css (right):

http://codereview.chromium.org/10830194/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/manage_profile_overlay.css:104:
#create-profile-content > :nth-last-child(2) {
Hmm, I don't think I'm a fan of this.  Which element specifically is the
:nth-last-child(2)?

[Halli, 2012-08-07 01:29:06]

http://codereview.chromium.org/10830194/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/manage_profile_overlay.css (right):

http://codereview.chromium.org/10830194/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/manage_profile_overlay.css:104:
#create-profile-content > :nth-last-child(2) {
This is the input area for name. I wanted to just change the margin for the last
element, but the pseudo element we added last CL is the last element now (the
grey divider line). And then I can't change the spacing for the pseudo element
to fix this problem because the decreased space is supposed to be between the
3rd and 2nd to last elements (the name label and name input).
Suggestions? (:
On 2012/08/07 01:26:34, James Hawkins wrote:
> Hmm, I don't think I'm a fan of this.  Which element specifically is the
> :nth-last-child(2)?

[Halli, 2012-08-07 02:12:42]

I forgot that the input box was inside of a div, so modifying it's margins did
nothing. Hopefully this solution is reasonable (:

[James Hawkins, 2012-08-07 16:47:14]

LGTM with nits.

http://codereview.chromium.org/10830194/diff/6003/chrome/browser/resources/op...
File chrome/browser/resources/options2/manage_profile_overlay.css (right):

http://codereview.chromium.org/10830194/diff/6003/chrome/browser/resources/op...
chrome/browser/resources/options2/manage_profile_overlay.css:129:
#manage-profile-content > #manage-profile-name-input-container {
nit: Combine this with the block above.

http://codereview.chromium.org/10830194/diff/6003/chrome/browser/resources/op...
chrome/browser/resources/options2/manage_profile_overlay.css:138:
#manage-profile-content > #manage-profile-name-label-container {
nit: Combine this with the block above.

[Halli, 2012-08-07 16:52:13]

http://codereview.chromium.org/10830194/diff/6003/chrome/browser/resources/op...
File chrome/browser/resources/options2/manage_profile_overlay.css (right):

http://codereview.chromium.org/10830194/diff/6003/chrome/browser/resources/op...
chrome/browser/resources/options2/manage_profile_overlay.css:129:
#manage-profile-content > #manage-profile-name-input-container {
On 2012/08/07 16:47:14, James Hawkins wrote:
> nit: Combine this with the block above.

Done.

http://codereview.chromium.org/10830194/diff/6003/chrome/browser/resources/op...
chrome/browser/resources/options2/manage_profile_overlay.css:138:
#manage-profile-content > #manage-profile-name-label-container {
On 2012/08/07 16:47:14, James Hawkins wrote:
> nit: Combine this with the block above.

Done.

[commit-bot: I haz the power, 2012-08-07 16:53:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hallielaine@chromium.org/10830194/9001

[commit-bot: I haz the power, 2012-08-07 17:57:34]

Change committed as 150370