Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: chrome/test/functional/ntp.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Used named arguments and deleted unused test files, as suggested by Nirnimesh. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/notifications.py ('k') | chrome/test/functional/omniboxmodel.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/ntp.py
diff --git a/chrome/test/functional/ntp.py b/chrome/test/functional/ntp.py
index 46312956b2644c5b7bf3a37898b0ce9a61154e27..f176943e70af227760bad1ad72505d0cbb7c4332 100755
--- a/chrome/test/functional/ntp.py
+++ b/chrome/test/functional/ntp.py
@@ -179,7 +179,7 @@ class NTPTest(pyauto.PyUITest):
"""Tests that closing a tab populates the recently closed list"""
self.RemoveNTPDefaultThumbnails()
self.AppendTab(pyauto.GURL(self.PAGES[1]['url']))
- self.GetBrowserWindow(0).GetTab(1).Close(True)
+ self.CloseTab(tab_index=1)
self.assertEqual(self.PAGES[1]['url'],
self.GetNTPRecentlyClosed()[0]['url'])
self.assertEqual(self.PAGES[1]['title'],
@@ -209,8 +209,8 @@ class NTPTest(pyauto.PyUITest):
self.RemoveNTPDefaultThumbnails()
self.AppendTab(pyauto.GURL(self.PAGES[0]['url']))
self.AppendTab(pyauto.GURL(self.PAGES[1]['url']))
- self.GetBrowserWindow(0).GetTab(2).Close(True)
- self.GetBrowserWindow(0).GetTab(1).Close(True)
+ self.CloseTab(tab_index=2)
+ self.CloseTab(tab_index=1)
expected = [{ u'type': u'tab',
u'url': self.PAGES[0]['url']
},
@@ -270,7 +270,7 @@ class NTPTest(pyauto.PyUITest):
self.NavigateToURL(self.PAGES[0]['url'], 1, 0)
self.AppendTab(pyauto.GURL(self.PAGES[0]['url']), 1)
self.AppendTab(pyauto.GURL(self.PAGES[1]['url']), 1)
- self.GetBrowserWindow(1).GetTab(0).Close(True)
+ self.CloseTab(windex=1)
self.assertFalse(self.GetNTPRecentlyClosed())
self.CloseBrowserWindow(1)
self.assertFalse(self.GetNTPRecentlyClosed())
« no previous file with comments | « chrome/test/functional/notifications.py ('k') | chrome/test/functional/omniboxmodel.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698