Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7411)

Unified Diff: chrome/test/functional/browser.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/functional/browser.py
diff --git a/chrome/test/functional/browser.py b/chrome/test/functional/browser.py
index 263ba1e4c7aec974c4a855012fd993af2181433d..de3b10c17d7e1583d5ed6e5e17b0f0de1eb4eae7 100755
--- a/chrome/test/functional/browser.py
+++ b/chrome/test/functional/browser.py
@@ -188,8 +188,8 @@ class BrowserTest(pyauto.PyUITest):
self.KillRendererProcess(shared_pid)
# Reload the parent and popup windows.
- self.GetBrowserWindow(0).GetTab(0).Reload()
- self.GetBrowserWindow(1).GetTab(0).Reload()
+ self.ReloadTab(0, 0)
Nirnimesh 2012/08/07 00:37:35 prefer named args, tab_index=0, windex=0 Or since
craigdh 2012/08/07 21:08:51 Done.
+ self.ReloadTab(0, 1)
Nirnimesh 2012/08/07 00:37:35 windex=1
craigdh 2012/08/07 21:08:51 Done.
# Check if both are sharing a process id.
self.assertEquals(
self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid'],

Powered by Google App Engine
This is Rietveld 408576698