Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4248)

Unified Diff: chrome/test/functional/navigation.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/functional/navigation.py
diff --git a/chrome/test/functional/navigation.py b/chrome/test/functional/navigation.py
index 5bf4885b280e5a3ace693b735fea501d4a5517f9..12c6034e4eca9ea80f68cef2feea06830817a173 100755
--- a/chrome/test/functional/navigation.py
+++ b/chrome/test/functional/navigation.py
@@ -49,9 +49,9 @@ class NavigationTest(pyauto.PyUITest):
self.assertEqual(2, self.GetTabCount(windex))
self.AppendTab(pyauto.GURL(urls[1]), windex)
self.assertEqual(3, self.GetTabCount(windex))
- self.GetBrowserWindow(windex).GetTab(2).Close(True)
+ self.CloseTab(2, windex)
self.assertEqual(2, self.GetTabCount(windex))
- self.GetBrowserWindow(windex).GetTab(1).Close(True)
+ self.CloseTab(1, windex)
self.assertEqual(1, self.GetTabCount(windex))
_OpenCloseTabsInWindow(0)
self.OpenNewBrowserWindow(True)
@@ -63,13 +63,12 @@ class NavigationTest(pyauto.PyUITest):
assert len(urls) >= 3, 'Need at least 3 urls.'
for url in urls:
self.NavigateToURL(url)
- tab = self.GetBrowserWindow(0).GetTab(0)
self.assertEqual(self.GetActiveTabURL().spec(), urls[-1])
for i in [-2, -3]:
- tab.GoBack()
+ self.TabGoBack()
self.assertEqual(self.GetActiveTabURL().spec(), urls[i])
for i in [-2, -1]:
- tab.GoForward()
+ self.TabGoForward()
self.assertEqual(self.GetActiveTabURL().spec(), urls[i])
def testCanDuplicateTab(self):

Powered by Google App Engine
This is Rietveld 408576698