Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4257)

Unified Diff: chrome/test/functional/media/worker_thread.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/functional/media/worker_thread.py
diff --git a/chrome/test/functional/media/worker_thread.py b/chrome/test/functional/media/worker_thread.py
index 983fb2f01d914ddf0917bb0ec78dc625b86cf478..d5d76069c5b0c9dd183ec367a5955078e8041995 100644
--- a/chrome/test/functional/media/worker_thread.py
+++ b/chrome/test/functional/media/worker_thread.py
@@ -105,7 +105,7 @@ class WorkerThread(threading.Thread):
self.AppendTab(unique_url)
if not self.RunTask(unique_url, task):
self.failures += 1
- self.CloseTab(unique_url)
+ self.CloseTabByURL(unique_url)
self.__tasks.task_done()
def __FindTabLocked(self, url):
@@ -138,10 +138,9 @@ class WorkerThread(threading.Thread):
tab_index=self.__FindTabLocked(url))
@synchronized
- def CloseTab(self, url):
+ def CloseTabByURL(self, url):
"""Closes the tab with the given url."""
- return self.__pyauto.GetBrowserWindow(0).GetTab(
- self.__FindTabLocked(url)).Close(True)
+ self.CloseTab(self.__FindTabLocked(url), 0)
@synchronized
def GetDOMValue(self, name, url=None):

Powered by Google App Engine
This is Rietveld 408576698