Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10830192: Rolling GYP to r1452: (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Rolling GYP to r1452: r1452: Pass include directorites to midl.exe. BUG=140324 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeypa (please no reviews)
PTAL.
8 years, 4 months ago (2012-08-06 23:50:29 UTC) #1
scottmg
lgtm
8 years, 4 months ago (2012-08-06 23:51:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10830192/1
8 years, 4 months ago (2012-08-07 00:03:29 UTC) #3
michaeln
ah... looks this should fix the busted windows build... great!
8 years, 4 months ago (2012-08-07 00:12:00 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 03:48:25 UTC) #5 
Change committed as 150249

Powered by Google App Engine
This is Rietveld 408576698