Fix status area tray spacing.

Fix status area tray spacing.


BUG=140870
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150573

[stevenjb, 2012-08-06 23:33:53]

http://codereview.chromium.org/10830190/diff/2001/ash/system/status_area_widg...
File ash/system/status_area_widget.h (right):

http://codereview.chromium.org/10830190/diff/2001/ash/system/status_area_widg...
ash/system/status_area_widget.h:75: internal::StatusAreaWidgetDelegate*
status_area_widget_delegate_;
Note: I discovered that this was shadowing Widget::widget_delegate_ so I renamed
it, even though I didn't end up using it.

[sadrul, 2012-08-07 13:40:56]

The status-widget needs to expand to the bottom and right edges of the screen.
This patch breaks that by removing the border (unfortunately we do not have a
test for this, we probably should).

[stevenjb, 2012-08-07 15:40:03]

On 2012/08/07 13:40:56, sadrul wrote:
> The status-widget needs to expand to the bottom and right edges of the screen.
> This patch breaks that by removing the border (unfortunately we do not have a
> test for this, we probably should).

I'm not sure I follow. The widget size doesn't change, do you mean the system
tray size? In that case I can put the outside spacing back in each tray.

[sadrul, 2012-08-07 17:05:00]

On 2012/08/07 15:40:03, stevenjb (chromium) wrote:
> On 2012/08/07 13:40:56, sadrul wrote:
> > The status-widget needs to expand to the bottom and right edges of the
screen.
> > This patch breaks that by removing the border (unfortunately we do not have
a
> > test for this, we probably should).
> 
> I'm not sure I follow. The widget size doesn't change, do you mean the system
> tray size? In that case I can put the outside spacing back in each tray.

I think the border of the tray-background affects the size of the widget too?
What we need is that the widget should extend to the right+bottom edges of the
screen so that they are hit-targets for mouse/touch (so if I move the mouse at
the bottom-right corner and click, it should trigger the popup). However it
still should have visual padding on both the right and the bottom.

[stevenjb, 2012-08-07 18:43:39]

OK, that makes sense. The tray views are the click targets, not the widget, so
we do need to put the spacing in the border. Updated the CL.
PTAL

[sadrul, 2012-08-08 15:01:19]

LGTM

[jennyz, 2012-08-08 17:34:50]

lgtm