Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 10830184: Remove V1 authenticators (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov
Modified:
8 years, 4 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove V1 chromoting authenticators After the last chrome remote desktop webapp update (version 1.6.1180.51) V1 authenticators should never be used, so it's safe to remove them now. BUG=110483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -383 lines) Patch
M remoting/protocol/authentication_method.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.h View 2 chunks +0 lines, -6 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.cc View 2 chunks +17 lines, -29 lines 0 comments Download
D remoting/protocol/v1_authenticator.h View 1 chunk +0 lines, -75 lines 0 comments Download
D remoting/protocol/v1_authenticator.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D remoting/protocol/v1_authenticator_unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
8 years, 4 months ago (2012-08-06 18:56:51 UTC) #1
Wez
Can you update the description to clarify that we're removing the Chromoting V1 authenticators, and ...
8 years, 4 months ago (2012-08-06 23:45:28 UTC) #2
Wez
8 years, 4 months ago (2012-08-06 23:49:58 UTC) #3
Sergey Ulanov
On 2012/08/06 23:45:28, Wez wrote: > Can you update the description to clarify that we're ...
8 years, 4 months ago (2012-08-06 23:57:01 UTC) #4
Sergey Ulanov
On 2012/08/06 23:57:01, sergeyu wrote: > On 2012/08/06 23:45:28, Wez wrote: > > Can you ...
8 years, 4 months ago (2012-08-06 23:58:17 UTC) #5
Wez
8 years, 4 months ago (2012-08-06 23:59:07 UTC) #6
Wez
lgtm
8 years, 4 months ago (2012-08-06 23:59:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10830184/1
8 years, 4 months ago (2012-08-07 00:01:25 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 01:33:15 UTC) #9
Change committed as 150225

Powered by Google App Engine
This is Rietveld 408576698