Built crypto and crypto_unittests for iOS

crypto/crypto.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     # Put all transitive dependencies for Windows HMAC here.
     # This is required so that we can build them for nacl win64.
     'hmac_win64_related_sources': [
@@ skipping 17 matching lines @@
         '../base/base.gyp:base',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
       ],
       'defines': [
         'CRYPTO_IMPLEMENTATION',
       ],
       'msvs_disabled_warnings': [
         4018,
       ],
       'conditions': [
-        [ 'os_posix == 1 and OS != "mac" and OS != "android"', {
+        [ 'os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', {
           'dependencies': [
             '../build/linux/system.gyp:ssl',
           ],
           'export_dependent_settings': [
             '../build/linux/system.gyp:ssl',
           ],
           'conditions': [
             [ 'chromeos==1', {
                 'sources/': [ ['include', '_chromeos\\.cc$'] ]
               },
             ],
           ],
-        }, {  # os_posix != 1 or OS == "mac" or OS == "android"
+        }, {  # os_posix != 1 or OS == "mac" or OS == "ios" or OS == "android"
             'sources/': [
               ['exclude', '_nss\.cc$'],
               ['include', 'ec_private_key_nss\.cc$'],
               ['include', 'ec_signature_creator_nss\.cc$'],
               ['include', 'encryptor_nss\.cc$'],
               ['include', 'hmac_nss\.cc$'],
               ['include', 'signature_verifier_nss\.cc$'],
               ['include', 'symmetric_key_nss\.cc$'],
             ],
             'sources!': [
@@ skipping 31 matching lines @@
             ],
           },
         }, {  # OS != "mac"
           'sources!': [
             'cssm_init.cc',
             'cssm_init.h',
             'mac_security_services_lock.cc',
             'mac_security_services_lock.h',
           ],
         }],
-        [ 'OS == "mac" or OS == "win"', {
+        [ 'OS == "mac" or OS == "ios" or OS == "win"', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nspr',
             '../third_party/nss/nss.gyp:nss',
           ],
           'export_dependent_settings': [
             '../third_party/nss/nss.gyp:nspr',
             '../third_party/nss/nss.gyp:nss',
           ],
         }],
         [ 'OS != "win"', {
@@ skipping 141 matching lines @@
         'openpgp_symmetric_encryption_unittest.cc',
       ],
       'dependencies': [
         'crypto',
         '../base/base.gyp:base',
         '../base/base.gyp:test_support_base',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
       ],
       'conditions': [
-        [ 'os_posix == 1 and OS != "mac" and OS != "android"', {
+        [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', {
           'conditions': [
             [ 'linux_use_tcmalloc==1', {
                 'dependencies': [
                   '../base/allocator/allocator.gyp:allocator',
                 ],
               },
             ],
           ],
           'dependencies': [
             '../build/linux/system.gyp:ssl',
           ],
-        }, {  # os_posix != 1 or OS == "mac" or OS == "android"
+        }, {  # os_posix != 1 or OS == "mac" or OS == "android" or OS == "ios"
           'sources!': [
             'rsa_private_key_nss_unittest.cc',
             'openpgp_symmetric_encryption_unittest.cc',
           ]
         }],
-        [ 'OS == "mac" or OS == "win"', {
+        [ 'OS == "mac" or OS == "ios" or OS == "win"', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nss',
           ],
         }],
+        ['OS == "ios"', {
+          'sources!': [
+            'rsa_private_key_unittest.cc',

[stuartmorgan, 2012/08/07 09:21:28]

Now it's not clear why these are excluded.

+wtc; can you explain what kind of TODO would make sense here, if any? Should we
file a bug for future work?

[wtc, 2012/08/08 18:09:58]

These tests are excluded because the classes they are testing
(RSAPrivateKey, SignatureCreator, and SignatureVerifier)
are not implemented for iOS.  I remember these classes
are used to sign and verify Chrome extensions.  Perhaps
Chrome on iOS does not support extensions?

In any case, we should add a comment that these tests
are excluded because they test classes that are not
implemented.

+            'signature_creator_unittest.cc',
+            'signature_verifier_unittest.cc',
+          ],
+        }],
         [ 'OS == "mac"', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nspr',
           ],
         }],
         [ 'use_openssl==1', {
           'sources!': [
             'nss_util_unittest.cc',
             'openpgp_symmetric_encryption_unittest.cc',
             'rsa_private_key_nss_unittest.cc',
@@ skipping 28 matching lines @@
           'configurations': {
             'Common_Base': {
               'msvs_target_platform': 'x64',
             },
           },
         },
       ],
     }],
   ],
 }