chrome/browser/chromeos/gdata/gdata_cache_metadata.h - Issue 10830181: Implement initialization for GDataCache to use in-memory metadata for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache_metadata.h

Issue 10830181: Implement initialization for GDataCache to use in-memory metadata for tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/gdata/gdata_cache.h ('K') | « chrome/browser/chromeos/gdata/gdata_cache.cc ('k') | chrome/browser/chromeos/gdata/gdata_cache_metadata.cc » ('j') | chrome/browser/chromeos/gdata/gdata_cache_metadata.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/gdata/gdata_cache_metadata.h

diff --git a/chrome/browser/chromeos/gdata/gdata_cache_metadata.h b/chrome/browser/chromeos/gdata/gdata_cache_metadata.h

index d6bebd516716b2ec5a52dbe65ac710e1949ac9e5..47d4153bc80495eb3b70f03a078ac23969756320 100644

--- a/chrome/browser/chromeos/gdata/gdata_cache_metadata.h

+++ b/chrome/browser/chromeos/gdata/gdata_cache_metadata.h

@@ -37,7 +37,7 @@ class GDataCacheMetadata {

// For testing, the thread assertion can be disabled by passing NULL and

// the default value of SequenceToken.

static scoped_ptr<GDataCacheMetadata> CreateGDataCacheMetadata(

- base::SequencedTaskRunner* blocking_task_runner);

+ base::SequencedTaskRunner* blocking_task_runner, bool use_map);

kochi 2012/08/06 09:02:17 We prefer enum to boolean for function arguments.

Haruki Sato 2012/08/08 05:00:42 Thank you for the advice. Removed the argument and

// Initialize the cache metadata store.

virtual void Initialize(const std::vector<FilePath>& cache_paths) = 0;