Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 10830180: Moving font_settings extensions API to api/ (Closed)

Created:
8 years, 4 months ago by vabr (Chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Moving font_settings extensions API to api/ and putting the classes into extensions namespace. TBR=ben@chromium.org BUG=101244 TEST=N/A, no code change, moving stuff around only Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150318

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moving "namespace extensions" up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -867 lines) Patch
A + chrome/browser/extensions/api/font_settings/font_settings_api.h View 4 chunks +11 lines, -7 lines 0 comments Download
A + chrome/browser/extensions/api/font_settings/font_settings_api.cc View 1 11 chunks +20 lines, -22 lines 0 comments Download
A + chrome/browser/extensions/api/font_settings/font_settings_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/extensions/extension_font_settings_api.h View 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/browser/extensions/extension_font_settings_api.cc View 1 chunk +0 lines, -483 lines 0 comments Download
D chrome/browser/extensions/extension_font_settings_apitest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
kalman@: Hi, could you please review this move of code? Putting ben@ in TBR for ...
8 years, 4 months ago (2012-08-06 09:24:46 UTC) #1
not at google - send to devlin
lgtm https://chromiumcodereview.appspot.com/10830180/diff/1/chrome/browser/extensions/api/font_settings/font_settings_api.cc File chrome/browser/extensions/api/font_settings/font_settings_api.cc (right): https://chromiumcodereview.appspot.com/10830180/diff/1/chrome/browser/extensions/api/font_settings/font_settings_api.cc#newcode32 chrome/browser/extensions/api/font_settings/font_settings_api.cc:32: namespace fonts = extensions::api::font_settings; if you pulled the ...
8 years, 4 months ago (2012-08-06 22:58:00 UTC) #2
vabr (Chromium)
Thanks! I addressed the comment, and will be shortly sending this into the CQ. Vaclav ...
8 years, 4 months ago (2012-08-07 07:25:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/10830180/1013
8 years, 4 months ago (2012-08-07 07:38:06 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 10:35:34 UTC) #5
Change committed as 150318

Powered by Google App Engine
This is Rietveld 408576698