Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 10830179: gdata: Save screenshot to /drive. (Closed)

Created:
8 years, 4 months ago by kinaba
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

gdata: Save screenshot to /drive. Note that this does not support the full functions of screenshots. It merely makes possible to save the screenshot .png file to /drive. What are *not* yet included in this patch are: - Show/upload the images from "Report issue" (crbug:140622). - Taking care of name collisions. For now, when a screenshot is taken after a short time period of another screenshot, the new comer will overwrite or recorded as ".. (1).png", depending on timing. Not quite good, but for M22, I hope it is better than nothing. BUG=138593 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150204

Patch Set 1 : #

Patch Set 2 : Add bug ID. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -22 lines) Patch
M chrome/browser/ui/ash/screenshot_taker.cc View 1 4 chunks +65 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
Mukai-san, can you take a look? (I'll soon file a bug for a name collision ...
8 years, 4 months ago (2012-08-06 04:55:55 UTC) #1
Jun Mukai
lgtm can you file an issue in case of multi-display and gdata screenshot?
8 years, 4 months ago (2012-08-06 05:12:51 UTC) #2
kinaba
> can you file an issue in case of multi-display and gdata screenshot? Filed a ...
8 years, 4 months ago (2012-08-06 08:13:25 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-06 19:37:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10830179/7002
8 years, 4 months ago (2012-08-06 23:40:47 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 01:08:09 UTC) #6
Change committed as 150204

Powered by Google App Engine
This is Rietveld 408576698