Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 10830178: About flag support for use-leveldb-for-gdata (Closed)

Created:
8 years, 4 months ago by achuithb
Modified:
8 years, 4 months ago
Reviewers:
satorux1, sky
CC:
chromium-reviews
Visibility:
Public.

Description

About flag support for use-leveldb-for-gdata BUG=127856 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
I think we should get this into m22.
8 years, 4 months ago (2012-08-04 09:29:55 UTC) #1
satorux1
LGTM
8 years, 4 months ago (2012-08-04 15:54:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10830178/1
8 years, 4 months ago (2012-08-04 19:20:33 UTC) #3
commit-bot: I haz the power
Presubmit check for 10830178-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-04 19:20:35 UTC) #4
achuithb
Scott: Need owner lgtm. This is a cros-only about flag that Zel has requested for ...
8 years, 4 months ago (2012-08-04 20:54:40 UTC) #5
sky
8 years, 4 months ago (2012-08-06 14:50:27 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698