JavaBridge should use Annotation

content/browser/android/content_view_core_impl.h

Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index e303371d3e5f08a4173b96fb8d42fa0f3597f5bf..4fabd87391a720041c64b478c3958ff189d240c5 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -117,7 +117,7 @@ class ContentViewCoreImpl : public ContentViewCore,
                               jobject obj,
                               jobject object,
                               jstring name,
-                              jboolean allow_inherited_methods);
+                              jboolean require_safe_annotation);

[Steve Block, 2012/08/06 12:12:30]

Bit of a nit, but referring to this as the 'safe annotation' seems odd, as the
annotation's name doesn't include the word 'safe'. Also, we don't know whether
the method is safe: we simply expose it if it's annotated. Maybe
'require_(method_)annotations' or 'expose_all_methods' to keep the current sense
of the boolean?

[palmer, 2012/08/06 17:31:26]

+1; I'd call it |require_annotations|.

[David Trainor- moved to gerrit, 2012/08/06 23:42:33]

Done.

   void RemoveJavascriptInterface(JNIEnv* env, jobject obj, jstring name);
 
   // --------------------------------------------------------------------------