Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Issue 10830171: Fix missing dependency on java inputs for ContentShellTest.apk. (Closed)

Created:
8 years, 4 months ago by Yaron
Modified:
8 years, 4 months ago
Reviewers:
Charlie Reis, nilesh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, bulach, cjhopman
Visibility:
Public.

Description

Fix missing dependency on java inputs for ContentShellTest.apk. This was causing the test to occasionly not pick up changes. Tested with: nbuild content_shell_test_apk && touch content/shell/android/javatests/src/org/chromium/content_shell/ContentShellUrlTest.java && nbuild content_shell_test_apk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yaron
jam for content rubberstamp Will be fixed properly when cjhopman templatizes more of these rules
8 years, 4 months ago (2012-08-03 21:21:59 UTC) #1
nilesh
On 2012/08/03 21:21:59, Yaron wrote: > jam for content rubberstamp > Will be fixed properly ...
8 years, 4 months ago (2012-08-03 21:24:26 UTC) #2
Yaron
-jam +creis (as jam is out). Hoping for content rubberstamp
8 years, 4 months ago (2012-08-03 23:31:53 UTC) #3
Charlie Reis
On 2012/08/03 23:31:53, Yaron wrote: > -jam +creis (as jam is out). Hoping for content ...
8 years, 4 months ago (2012-08-04 00:18:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10830171/1
8 years, 4 months ago (2012-08-04 00:44:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10830171/1
8 years, 4 months ago (2012-08-06 23:38:08 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 01:15:12 UTC) #7
Change committed as 150210

Powered by Google App Engine
This is Rietveld 408576698