Retry: [CrOS] Enumerate existing mount points and check for media devices.

Retry: [CrOS] Enumerate existing mount points and check for media devices.

Fixed unit test failures.

Original review CL: http://codereview.chromium.org/10843061

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149936

[kmadhusu, 2012-08-03 18:37:45]

tbarzic: Please review mock_disk_mount_manager changes.
thestig: Please review media_device_notifications_chromeos changes.

Thanks.

[Lei Zhang, 2012-08-03 18:39:54]

lgtm

https://chromiumcodereview.appspot.com/10830165/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/disks/mock_disk_mount_manager.h (right):

https://chromiumcodereview.appspot.com/10830165/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/disks/mock_disk_mount_manager.h:73: const
DiskMountManager::MountPointMap& mountPointsInternal() const;
mountPointsInternalForTest() ?

[tbarzic, 2012-08-03 18:42:49]

lgtm

https://chromiumcodereview.appspot.com/10830165/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/disks/mock_disk_mount_manager.h (right):

https://chromiumcodereview.appspot.com/10830165/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/disks/mock_disk_mount_manager.h:73: const
DiskMountManager::MountPointMap& mountPointsInternal() const;
On 2012/08/03 18:39:54, Lei Zhang wrote:
> mountPointsInternalForTest() ?

I don't think "ForTest" is needed.. this is a mock class, so it's obvious it is
used only in test..

[kmadhusu, 2012-08-03 18:42:51]

https://chromiumcodereview.appspot.com/10830165/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/disks/mock_disk_mount_manager.h (right):

https://chromiumcodereview.appspot.com/10830165/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/disks/mock_disk_mount_manager.h:73: const
DiskMountManager::MountPointMap& mountPointsInternal() const;
On 2012/08/03 18:39:54, Lei Zhang wrote:
> mountPointsInternalForTest() ?

The current name matches other helper function names. So, I would like to leave
it as it is.

[commit-bot: I haz the power, 2012-08-03 18:46:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10830165/1

[commit-bot: I haz the power, 2012-08-03 21:55:39]

Change committed as 149936