Issue 10830160: Fix crash bug when calling getV8Statistics().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830160: Fix crash bug when calling getV8Statistics(). (Closed)

Created:
8 years, 4 months ago by Yang

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix crash bug when calling getV8Statistics(). BUG=v8:2270 Committed: https://code.google.com/p/v8/source/detail?r=12255

Patch Set 2 : addressed comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -26 lines)			Patch
	M	src/extensions/statistics-extension.cc	View	1	2 chunks	+22 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a comment). http://codereview.chromium.org/10830160/diff/1/src/extensions/statistics-extension.cc File src/extensions/statistics-extension.cc (right): http://codereview.chromium.org/10830160/diff/1/src/extensions/statistics-extension.cc#newcode97 src/extensions/statistics-extension.cc:97: if (result->GetOwnPropertyNames()->Length() == 0) { ...

8 years, 4 months ago (2012-08-03 13:58:28 UTC) #2

Yang

8 years, 4 months ago (2012-08-03 14:03:21 UTC) #3

On 2012/08/03 13:58:28, Michael Starzinger wrote:
> LGTM (with a comment).
> 
>
http://codereview.chromium.org/10830160/diff/1/src/extensions/statistics-exte...
> File src/extensions/statistics-extension.cc (right):
> 
>
http://codereview.chromium.org/10830160/diff/1/src/extensions/statistics-exte...
> src/extensions/statistics-extension.cc:97: if
> (result->GetOwnPropertyNames()->Length() == 0) {
> Why do we need to throw an exception here? Wouldn't it be more JavaScript-ish
to
> just return the empty object?

Alright. Done. Committing.

Expand Messages | Collapse Messages

Issue 10830160: Fix crash bug when calling getV8Statistics(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages