Refactor GrabWindowSnapshot and GrabWindowSnapshotImpl names to GrabWindowSnapshotForUser and GrabW…

chrome/browser/ui/window_snapshot/window_snapshot.h

Index: chrome/browser/ui/window_snapshot/window_snapshot.h
diff --git a/chrome/browser/ui/window_snapshot/window_snapshot.h b/chrome/browser/ui/window_snapshot/window_snapshot.h
index bad52012aefd21c6f7ae39856540e8154468b70a..cb455b1c5209a97364a6661e6ebc74b97b5c0f6d 100644
--- a/chrome/browser/ui/window_snapshot/window_snapshot.h
+++ b/chrome/browser/ui/window_snapshot/window_snapshot.h
@@ -20,7 +20,20 @@ namespace chrome {
 // Grabs a snapshot of the rectangle area |snapshot_bounds| with respect to the
 // top left corner of the designated window and stores a PNG representation
 // into a byte vector. On Windows, |window| may be NULL to grab a snapshot of
-// the primary monitor. Returns true if the operation is successful.
+// the primary monitor. This takes into account calling user context (ie. checks
+// policy settings if taking screenshots is allowed), and is intended to by used

[grt (UTC plus 2), 2012/08/03 20:50:45]

"to by" -> "to be"

[qfel, 2012/08/06 08:49:10]

Done.

+// by browser code. If you need to take a screenshot for debugging purposes,
+// consider using GrabWindowSnapshot.
+// Returns true if the operation is successful (ie. permitted).
+bool GrabWindowSnapshotForUser(
+    gfx::NativeWindow window,
+    std::vector<unsigned char>* png_representation,
+    const gfx::Rect& snapshot_bounds);
+
+// Like GrabWindowSnapshotForUser, but does not perform additional security
+// checks - just grabs a snapshot. This is intended to be used for debugging
+// purposes where no BrowserProcess instance is available (ie. tests).
+// DO NOT use in a result of user action.
 bool GrabWindowSnapshot(

[sky, 2012/08/03 17:24:59]

move this into an internal namespace (inside the chrome namespace) to make it
more obvious others shouldn't use it.

[qfel, 2012/08/06 08:49:10]

Done.

     gfx::NativeWindow window,
     std::vector<unsigned char>* png_representation,