Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10830153: Adjust the audio frame count. (Closed)

Created:
8 years, 4 months ago by brettw
Modified:
8 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Adjust the audio frame count. This sets 2048 to select the high-latency path rather than the low one. This allows us to make Flash use power-of-two buffers and still get the high latency path, avoiding bugs in the current low-latency path. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149750

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/pepper/pepper_platform_audio_output_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
8 years, 4 months ago (2012-08-02 23:39:50 UTC) #1
viettrungluu
LGTM either way, but see the comment below. https://chromiumcodereview.appspot.com/10830153/diff/1/content/renderer/pepper/pepper_platform_audio_output_impl.cc File content/renderer/pepper/pepper_platform_audio_output_impl.cc (right): https://chromiumcodereview.appspot.com/10830153/diff/1/content/renderer/pepper/pepper_platform_audio_output_impl.cc#newcode123 content/renderer/pepper/pepper_platform_audio_output_impl.cc:123: const ...
8 years, 4 months ago (2012-08-02 23:42:22 UTC) #2
brettw
New snap up
8 years, 4 months ago (2012-08-02 23:47:22 UTC) #3
viettrungluu
8 years, 4 months ago (2012-08-02 23:47:45 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698