Issue 10830150: Increase the number of wave out buffers to 4 for Vista.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830150: Increase the number of wave out buffers to 4 for Vista. (Closed)

Created:
8 years, 4 months ago by viettrungluu

Modified:
8 years, 4 months ago

Reviewers:
cpu_(ooo_6.6-7.5), scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Increase the number of wave out buffers to 4 for Vista. We found that, with Pepper plugins (e.g., Pepper Flash), even 50 ms buffers weren't enough to avoid occasional clicks (with 3 wave out buffers). (On my Vista test machine with 4 wave out buffers we could manage ~43 ms buffers.) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149741

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	media/audio/audio_util.cc	View		1 chunk	+13 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages