Issue 10830148: Fixes bug in MultiWindowResizeController where it wasn't removing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830148: Fixes bug in MultiWindowResizeController where it wasn't removing (Closed)

Created:
8 years, 4 months ago by sky

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes bug in MultiWindowResizeController where it wasn't removing observers properly if the resizer stayed visible after a resize. BUG=139227 TEST=covered by unit tests R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149756

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	ash/wm/workspace/multi_window_resize_controller.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
	M	ash/wm/workspace/multi_window_resize_controller_unittest.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10830148/1

8 years, 4 months ago (2012-08-02 23:05:25 UTC) #3

Change committed as 149756