Issue 3847. Allow non-constant instance variable initializers

Issue 3847. Allow non-constant instance variable initializers
http://code.google.com/p/dart/issues/detail?id=3847


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10233

[Brian Wilkerson, 2012-08-02 21:19:50]

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java
(right):

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:628:
if (isFinalTopLevelField || (isClassField && isStatic) || isConst) {
I do not think that it is necessary for top-level final fields to be initialized
to a constant anymore.

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:805:
ResolverErrorCode.CANNOT_USE_THIS_IN_INSTANCE_FIELD_INITIALIZER));
CANNOT_USE_INSTANCE_FIELD_...?

[scheglov, 2012-08-02 22:07:41]

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java
(right):

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:628:
if (isFinalTopLevelField || (isClassField && isStatic) || isConst) {
On 2012/08/02 21:19:50, Brian Wilkerson wrote:
> I do not think that it is necessary for top-level final fields to be
initialized
> to a constant anymore.

1. Issue speak only about instance fields.

2. "Changes since Version 0.10" tells "Instance variables can be initialized to
non-constants." and also "Evaluation rules to allow instance variables with
non-constant initializers".

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:805:
ResolverErrorCode.CANNOT_USE_THIS_IN_INSTANCE_FIELD_INITIALIZER));
On 2012/08/02 21:19:50, Brian Wilkerson wrote:
> CANNOT_USE_INSTANCE_FIELD_...?

Done.

[Brian Wilkerson, 2012-08-02 22:16:35]

LGTM

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java
(right):

https://chromiumcodereview.appspot.com/10830145/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:628:
if (isFinalTopLevelField || (isClassField && isStatic) || isConst) {
> 2. "Changes since Version 0.10"

I'm not sure what that is, I was basing my comments off the revised spec, but if
this bug doesn't cover those changes then I'm sure we'll get to it later.