GTK implementation of the action box button.

GTK implementation of the action box button.

Does nothing so far.

TBR=ben@chromium.org
BUG=125307
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149840

[Matt Perry, 2012-08-02 17:06:17]

kalman: please review (I'm planning on making you the review man for action box
stuff, if that's OK with you).
erg: ui/gtk OWNERS

[Elliot Glaysher, 2012-08-02 17:33:06]

gtk stamp

As is, that's a reasonable skeleton.

[Elliot Glaysher, 2012-08-02 17:33:12]

lgtm

[not at google - send to devlin, 2012-08-02 18:27:55]

lgtm

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/action_b...
File chrome/browser/ui/gtk/action_box_button_gtk.h (right):

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/action_b...
chrome/browser/ui/gtk/action_box_button_gtk.h:30: scoped_ptr<CustomDrawButton>
button_;
forward declare?

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/location...
File chrome/browser/ui/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/location...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:475: // TODO(mpcomplete): should
we hide this if ShouldOnlyShowLocation()==true?
Since it's hiding the star if it isn't, I'd expect the answer to be yes.

Also I'd generally expect the answer to be yes?

[Matt Perry, 2012-08-03 09:57:42]

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/action_b...
File chrome/browser/ui/gtk/action_box_button_gtk.h (right):

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/action_b...
chrome/browser/ui/gtk/action_box_button_gtk.h:30: scoped_ptr<CustomDrawButton>
button_;
On 2012/08/02 18:27:55, kalman wrote:
> forward declare?

Done. However, it required a small violation of the style guide: I had to move
widget()'s implementation to the .cc file. (I'd rather not rename it to
GetWidget() - blech.)

I'm OK with this.

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/location...
File chrome/browser/ui/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/10830140/diff/1/chrome/browser/ui/gtk/location...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:475: // TODO(mpcomplete): should
we hide this if ShouldOnlyShowLocation()==true?
On 2012/08/02 18:27:55, kalman wrote:
> Since it's hiding the star if it isn't, I'd expect the answer to be yes.
> 
> Also I'd generally expect the answer to be yes?

As would I. But this is a new thingy, so maybe the design is meant to be
different. Who knows.

I'm just going to leave it as is, since that's the way it is for views. When I
find out it's wrong, I'll change all the platforms at once.

[Matt Perry, 2012-08-03 09:58:33]

TBR'ing ben for chrome/ OWNERS

[commit-bot: I haz the power, 2012-08-03 09:58:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10830140/3002

[commit-bot: I haz the power, 2012-08-03 12:21:34]

Change committed as 149840

[Ben Goodger (Google), 2012-08-03 17:08:15]

lgtm