Issue 10830138: Disable captive portal detection prior to merging to M22

Issue 10830138: Disable captive portal detection prior to merging to M22 (Closed)

Created:
8 years, 4 months ago by mmenke

Modified:
8 years, 4 months ago

Reviewers:
cbentzel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Disable captive portal detection prior to merging to M22. BUG=141134 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150875

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/captive_portal/captive_portal_service.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 9 (0 generated)

cbentzel

LGTM Another option is to disable after branch and merge.

8 years, 4 months ago (2012-08-02 17:40:28 UTC) #2

mmenke

On 2012/08/02 17:40:28, cbentzel wrote: > LGTM > > Another option is to disable after ...

8 years, 4 months ago (2012-08-02 17:45:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10830138/5002

8 years, 4 months ago (2012-08-09 15:48:12 UTC) #4

cbentzel

On 2012/08/09 15:49:02, Matt Menke wrote: > Oops. Fixed description. LGTM

8 years, 4 months ago (2012-08-09 16:09:05 UTC) #6

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

8 years, 4 months ago (2012-08-09 17:22:44 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10830138/5002

8 years, 4 months ago (2012-08-09 17:27:40 UTC) #8

Change committed as 150875