Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: runtime/vm/parser.cc

Issue 10830130: Properly skip expressions that contain the operator as. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/type_cast_vm_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 10146)
+++ runtime/vm/parser.cc (working copy)
@@ -8832,8 +8832,11 @@
void Parser::SkipBinaryExpr() {
SkipUnaryExpr();
- while (Token::Precedence(Token::kOR) <= Token::Precedence(CurrentToken()) &&
- Token::Precedence(CurrentToken()) <= Token::Precedence(Token::kMUL)) {
+ const int min_prec = Token::Precedence(Token::kOR);
+ const int max_prec = Token::Precedence(Token::kMUL);
+ while (((min_prec <= Token::Precedence(CurrentToken())) &&
+ (Token::Precedence(CurrentToken()) <= max_prec)) ||
+ IsLiteral("as")) {
ConsumeToken();
SkipUnaryExpr();
}
« no previous file with comments | « no previous file | tests/language/type_cast_vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698