Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Side by Side Diff: chrome/chrome.gyp

Issue 10830126: Do not pass -dead_strip to ld for the Mac helper and main apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'chromium_code': 1, 6 'chromium_code': 1,
7 7
8 'variables': { 8 'variables': {
9 'version_py_path': 'tools/build/version.py', 9 'version_py_path': 'tools/build/version.py',
10 'version_path': 'VERSION', 10 'version_path': 'VERSION',
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 # resources directory. 413 # resources directory.
414 'mac_bundle_resources/': [ 414 'mac_bundle_resources/': [
415 ['exclude', '.*'], 415 ['exclude', '.*'],
416 ], 416 ],
417 'xcode_settings': { 417 'xcode_settings': {
418 'CHROMIUM_BUNDLE_ID': '<(mac_bundle_id)', 418 'CHROMIUM_BUNDLE_ID': '<(mac_bundle_id)',
419 'CHROMIUM_SHORT_NAME': '<(branding)', 419 'CHROMIUM_SHORT_NAME': '<(branding)',
420 'CHROMIUM_STRIP_SAVE_FILE': 'app/app.saves', 420 'CHROMIUM_STRIP_SAVE_FILE': 'app/app.saves',
421 'INFOPLIST_FILE': 'app/helper-Info.plist', 421 'INFOPLIST_FILE': 'app/helper-Info.plist',
422 }, 422 },
423 # Turn off -dead_strip in Release mode for the main app. There's
424 # little here to strip, and doing so preserves symbols from
425 # crt1.10.6.o, which get removed incorrectly. http://crbug.com/139902
426 'configurations': {
427 'Release': {
428 'xcode_settings': {
429 'DEAD_CODE_STRIPPING': 'NO',
430 },
431 },
432 },
423 'postbuilds': [ 433 'postbuilds': [
424 { 434 {
425 # The helper doesn't have real localizations, it just has 435 # The helper doesn't have real localizations, it just has
426 # empty .lproj directories, which is enough to convince Cocoa 436 # empty .lproj directories, which is enough to convince Cocoa
427 # that anything running out of the helper .app supports those 437 # that anything running out of the helper .app supports those
428 # languages. 438 # languages.
429 'postbuild_name': 'Make Empty Localizations', 439 'postbuild_name': 'Make Empty Localizations',
430 'variables': { 440 'variables': {
431 'locale_dirs': [ 441 'locale_dirs': [
432 '>!@(<(apply_locales_cmd) -d ZZLOCALE.lproj <(locales))', 442 '>!@(<(apply_locales_cmd) -d ZZLOCALE.lproj <(locales))',
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 'sources': [ 1068 'sources': [
1059 'browser/safe_browsing/signature_util.h', 1069 'browser/safe_browsing/signature_util.h',
1060 'browser/safe_browsing/signature_util_win.cc', 1070 'browser/safe_browsing/signature_util_win.cc',
1061 'tools/safe_browsing/sb_sigutil.cc', 1071 'tools/safe_browsing/sb_sigutil.cc',
1062 ], 1072 ],
1063 }, 1073 },
1064 ]}, # 'targets' 1074 ]}, # 'targets'
1065 ], # OS=="win" 1075 ], # OS=="win"
1066 ], # 'conditions' 1076 ], # 'conditions'
1067 } 1077 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698