Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 10830124: Removed checks that verify URLRequest has a Context (Closed)

Created:
8 years, 4 months ago by shalev
Modified:
8 years, 4 months ago
CC:
chromium-reviews, robertshield, cbentzel+watch_chromium.org, kkania, darin-cc_chromium.org
Visibility:
Public.

Description

Removed checks that verify URLRequest has a Context Due to a recent cl, URLRequest must get a non-NULL context in the constructor. This means that if-statements and DCHECKs that verify the existence of context are no longer needed. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -60 lines) Patch
M chrome/browser/automation/url_request_automation_job.cc View 1 chunk +13 lines, -15 lines 0 comments Download
M net/url_request/url_request.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 10 chunks +21 lines, -28 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M net/url_request/url_request_throttler_entry.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
shalev
Hi Matt, Please take a look. Shalev
8 years, 4 months ago (2012-08-02 18:23:57 UTC) #1
mmenke
On 2012/08/02 18:23:57, shalev wrote: > Hi Matt, > > Please take a look. > ...
8 years, 4 months ago (2012-08-02 18:29:42 UTC) #2
shalev
Hi Pawel, Can I get an OWNERS review of this cl for chrome/browser/automation? Thanks, Shalev
8 years, 4 months ago (2012-08-03 15:35:10 UTC) #3
darin (slow to review)
LGTM for automation/
8 years, 4 months ago (2012-08-13 07:27:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shalev@chromium.org/10830124/1
8 years, 4 months ago (2012-08-13 15:07:43 UTC) #5
commit-bot: I haz the power
Try job failure for 10830124-1 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-13 17:50:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shalev@chromium.org/10830124/1
8 years, 4 months ago (2012-08-13 18:20:43 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 19:35:49 UTC) #8
Change committed as 151326

Powered by Google App Engine
This is Rietveld 408576698