Issue 10830121: Respect 'include_all_files' parameter in ChromeOS file Open/Save dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830121: Respect 'include_all_files' parameter in ChromeOS file Open/Save dialogs (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev

Modified:
8 years, 4 months ago

Reviewers:
SeRya

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Respect 'include_all_files' parameter in ChromeOS file Open/Save dialogs BUG=133866 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149618

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -25 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1	3 chunks	+44 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_type.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

SeRya

lgtm http://codereview.chromium.org/10830121/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/10830121/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode1418 chrome/browser/resources/file_manager/js/file_manager.js:1418: return '*.' + s; 1. Indention. 2. Initially ...

8 years, 4 months ago (2012-08-02 09:01:18 UTC) #2

BUG=133866

Expand Messages | Collapse Messages