Issue 10830118: net: add codereview sites to HSTS preloaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830118: net: add codereview sites to HSTS preloaded. (Closed)

Created:
8 years, 4 months ago by agl

Modified:
8 years, 4 months ago

Reviewers:
palmer

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: add codereview sites to HSTS preloaded. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149851

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)			Patch
M	net/base/transport_security_state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/transport_security_state_static.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/base/transport_security_state_static.json	View	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

This came up on a thread recently. Anything that I've missed?

8 years, 4 months ago (2012-08-01 14:38:26 UTC) #1

palmer

8 years, 4 months ago (2012-08-01 18:39:09 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10830118/diff/1/net/base/transport_sec...
File net/base/transport_security_state_static.json (right):

https://chromiumcodereview.appspot.com/10830118/diff/1/net/base/transport_sec...
net/base/transport_security_state_static.json:169: { "name":
"codereview.appspot.com", "include_subdomains": true, "mode": "force-https",
"pins": "google" },
Also codereview.chromium.org is a synonym.  Of course, it doesn't currently
work, which is a seperate issue... I've pinged the appropriate people.

Expand Messages | Collapse Messages