Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Side by Side Diff: chrome/browser/chromeos/login/user_image_loader.cc

Issue 10830111: [cros] Encode user images when set from WebUI (regression fix). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/user_image_loader.h" 5 #include "chrome/browser/chromeos/login/user_image_loader.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/file_path.h" 8 #include "base/file_path.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/message_loop.h" 11 #include "base/message_loop.h"
12 #include "chrome/browser/chromeos/login/helper.h" 12 #include "chrome/browser/chromeos/login/helper.h"
13 #include "chrome/browser/chromeos/login/user_image.h" 13 #include "chrome/browser/chromeos/login/user_image.h"
14 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
15 #include "skia/ext/image_operations.h" 15 #include "skia/ext/image_operations.h"
16 #include "third_party/skia/include/core/SkBitmap.h" 16 #include "third_party/skia/include/core/SkBitmap.h"
17 #include "ui/gfx/codec/png_codec.h" 17 #include "ui/gfx/codec/png_codec.h"
18 #include "ui/gfx/skbitmap_operations.h" 18 #include "ui/gfx/skbitmap_operations.h"
19 19
20 using content::BrowserThread; 20 using content::BrowserThread;
21 21
22 namespace chromeos { 22 namespace chromeos {
23 23
24 UserImageLoader::ImageInfo::ImageInfo(int size, 24 UserImageLoader::ImageInfo::ImageInfo(int size,
25 bool load_raw_image,
26 const LoadedCallback& loaded_cb) 25 const LoadedCallback& loaded_cb)
27 : size(size), 26 : size(size),
28 load_raw_image(load_raw_image),
29 loaded_cb(loaded_cb) { 27 loaded_cb(loaded_cb) {
30 } 28 }
31 29
32 UserImageLoader::ImageInfo::~ImageInfo() { 30 UserImageLoader::ImageInfo::~ImageInfo() {
33 } 31 }
34 32
35 UserImageLoader::UserImageLoader() 33 UserImageLoader::UserImageLoader()
36 : target_message_loop_(NULL) { 34 : target_message_loop_(NULL) {
37 } 35 }
38 36
39 UserImageLoader::~UserImageLoader() { 37 UserImageLoader::~UserImageLoader() {
40 } 38 }
41 39
42 void UserImageLoader::Start(const std::string& filepath, 40 void UserImageLoader::Start(const std::string& filepath,
43 int size, 41 int size,
44 bool load_raw_image,
45 const LoadedCallback& loaded_cb) { 42 const LoadedCallback& loaded_cb) {
46 target_message_loop_ = MessageLoop::current(); 43 target_message_loop_ = MessageLoop::current();
47 44
48 ImageInfo image_info(size, load_raw_image, loaded_cb); 45 ImageInfo image_info(size, loaded_cb);
49 BrowserThread::PostTask( 46 BrowserThread::PostTask(
50 BrowserThread::FILE, FROM_HERE, 47 BrowserThread::FILE, FROM_HERE,
51 base::Bind(&UserImageLoader::LoadImage, this, filepath, image_info)); 48 base::Bind(&UserImageLoader::LoadImage, this, filepath, image_info));
52 } 49 }
53 50
54 void UserImageLoader::LoadImage(const std::string& filepath, 51 void UserImageLoader::LoadImage(const std::string& filepath,
55 const ImageInfo& image_info) { 52 const ImageInfo& image_info) {
56 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 53 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
57 54
58 std::string image_data; 55 std::string image_data;
(...skipping 30 matching lines...) Expand all
89 final_image = 86 final_image =
90 skia::ImageOperations::Resize(cropped_image, 87 skia::ImageOperations::Resize(cropped_image,
91 skia::ImageOperations::RESIZE_LANCZOS3, 88 skia::ImageOperations::RESIZE_LANCZOS3,
92 image_info.size, 89 image_info.size,
93 image_info.size); 90 image_info.size);
94 } else { 91 } else {
95 final_image = cropped_image; 92 final_image = cropped_image;
96 } 93 }
97 } 94 }
98 95
99 scoped_ptr<UserImage> user_image;
100 if (image_info.load_raw_image)
101 user_image.reset(new UserImage(final_image, decoder->get_image_data()));
102 else
103 user_image.reset(new UserImage(final_image));
104
105 target_message_loop_->PostTask( 96 target_message_loop_->PostTask(
106 FROM_HERE, 97 FROM_HERE,
107 base::Bind(image_info.loaded_cb, *user_image)); 98 base::Bind(image_info.loaded_cb,
99 UserImage(final_image, decoder->get_image_data())));
108 100
109 image_info_map_.erase(info_it); 101 image_info_map_.erase(info_it);
110 } 102 }
111 103
112 void UserImageLoader::OnDecodeImageFailed(const ImageDecoder* decoder) { 104 void UserImageLoader::OnDecodeImageFailed(const ImageDecoder* decoder) {
113 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 105 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
114 image_info_map_.erase(decoder); 106 image_info_map_.erase(decoder);
115 } 107 }
116 108
117 } // namespace chromeos 109 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698