Issue 10830108: Fix handling of optional argument to -j.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830108: Fix handling of optional argument to -j. (Closed)

Created:
8 years, 4 months ago by szager1

Modified:
8 years, 4 months ago

Reviewers:
cmp, szager

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Fix handling of optional argument to -j. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149649

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -15 lines)			Patch
	M	git-crup	View	1 2	4 chunks	+32 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cmp

lgtm with nit https://chromiumcodereview.appspot.com/10830108/diff/3/git-crup File git-crup (right): https://chromiumcodereview.appspot.com/10830108/diff/3/git-crup#newcode50 git-crup:50: ;; increase indent on lines 49-50 ...

8 years, 4 months ago (2012-08-02 17:21:53 UTC) #2

szager

https://chromiumcodereview.appspot.com/10830108/diff/3/git-crup File git-crup (right): https://chromiumcodereview.appspot.com/10830108/diff/3/git-crup#newcode50 git-crup:50: ;; On 2012/08/02 17:21:53, cmp wrote: > increase indent ...

8 years, 4 months ago (2012-08-02 17:23:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/10830108/5001

8 years, 4 months ago (2012-08-02 17:28:45 UTC) #4

Change committed as 149649

Expand Messages | Collapse Messages

Issue 10830108: Fix handling of optional argument to -j. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages