Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 10830104: Changed VS add-in to use nacl-gdb (Closed)

Created:
8 years, 4 months ago by tysand
Modified:
8 years, 4 months ago
Reviewers:
noelallen1
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Changed VS add-in to use nacl-gdb Switched from the Custom GDB hack to the real nacl-gdb. BUG=136414 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1406

Patch Set 1 #

Total comments: 1

Patch Set 2 : IrtPath Property added #

Messages

Total messages: 3 (0 generated)
tysand
8 years, 4 months ago (2012-07-31 22:09:06 UTC) #1
noelallen1
LGTM http://codereview.chromium.org/10830104/diff/1/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerHelper.cs File visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerHelper.cs (right): http://codereview.chromium.org/10830104/diff/1/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerHelper.cs#newcode279 visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerHelper.cs:279: irtPath_ = Path.Combine(sdkRootDirectory_, @"tools\irt_x86_64.nexe"); Would be nice if ...
8 years, 4 months ago (2012-08-01 01:34:20 UTC) #2
tysand
8 years, 4 months ago (2012-08-01 06:15:30 UTC) #3
I've added the IRT path as a property.
On 2012/08/01 01:34:20, noelallen1 wrote:
> LGTM
> 
>
http://codereview.chromium.org/10830104/diff/1/visual_studio/NativeClientVSAd...
> File
> visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerHelper.cs
> (right):
> 
>
http://codereview.chromium.org/10830104/diff/1/visual_studio/NativeClientVSAd...
>
visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerHelper.cs:279:
> irtPath_ = Path.Combine(sdkRootDirectory_, @"tools\irt_x86_64.nexe");
> Would be nice if we could specify the path...  Otherwise we kinda need the one
> that exactly matches chrome.  Otherwise the symbols will be wrong.
> 
> Should probably file a feature request bug to see if we can do something
better.

Powered by Google App Engine
This is Rietveld 408576698