Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_store.cc

Issue 10830082: Deal gracefully with removing content settings for unregistered extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/content_settings/content_settings_store.cc
diff --git a/chrome/browser/extensions/api/content_settings/content_settings_store.cc b/chrome/browser/extensions/api/content_settings/content_settings_store.cc
index 84408d99a29a9892d27644a4f02c53fd71cf54f0..802cac95b780e4fc4e1829d0c2872a9ef99258d0 100644
--- a/chrome/browser/extensions/api/content_settings/content_settings_store.cc
+++ b/chrome/browser/extensions/api/content_settings/content_settings_store.cc
@@ -235,8 +235,8 @@ void ContentSettingsStore::ClearContentSettingsForExtension(
char ext_id_buffer[33];
base::strlcpy(ext_id_buffer, ext_id.c_str(), sizeof(ext_id_buffer));
base::debug::Alias(ext_id_buffer);
- // Do a clean crash.
- CHECK(false);
+ // Gracefully return instead of crashing below.
+ return;
}
notify = !map->empty();
map->clear();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698