Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 10830081: Remove code that sets |deltaX| and |deltaY| for WebKit gesture tap events (Closed)

Created:
8 years, 4 months ago by tdanderson
Modified:
8 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove code that sets |deltaX| and |deltaY| for WebKit gesture tap events Once https://bugs.webkit.org/show_bug.cgi?id=92151 lands and is gardened in, WebKit gesture tap events will use |boundingBox| instead of |deltaX| and |deltaY| to determine the gesture's touch region, so these special cases may be removed. BUG=138572 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tdanderson
Patch up for review that removes some obsolete code.
8 years, 4 months ago (2012-07-31 00:01:16 UTC) #1
sadrul
On 2012/07/31 00:01:16, tdanderson wrote: > Patch up for review that removes some obsolete code. ...
8 years, 4 months ago (2012-07-31 04:04:00 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-31 15:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/10830081/1
8 years, 4 months ago (2012-07-31 15:50:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/10830081/1
8 years, 4 months ago (2012-08-01 15:21:19 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 17:07:36 UTC) #6
Change committed as 149432

Powered by Google App Engine
This is Rietveld 408576698