Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10830076: Drive: fix the DCHECK condition on stopping update watch. (Closed)

Created:
8 years, 4 months ago by yoshiki
Modified:
8 years, 4 months ago
Reviewers:
hshi1
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Drive: fix the DCHECK condition on stopping update watch. BUG=none R=hshi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
hshi: Hi! I found a suspected mistake in the code where you seem to write ...
8 years, 4 months ago (2012-07-30 22:45:59 UTC) #1
hshi1
Thank you very much for catching this problem! LGTM.
8 years, 4 months ago (2012-07-30 22:50:07 UTC) #2
yoshiki
satorux: could you take a look as a owner?
8 years, 4 months ago (2012-07-31 00:05:20 UTC) #3
hshi1
On 2012/07/31 00:05:20, yoshiki wrote: > satorux: could you take a look as a owner? ...
8 years, 4 months ago (2012-08-01 01:19:10 UTC) #4
yoshiki
Got it, thanks!
8 years, 4 months ago (2012-08-01 01:40:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10830076/1
8 years, 4 months ago (2012-08-01 01:54:30 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 03:37:03 UTC) #7
Change committed as 149366

Powered by Google App Engine
This is Rietveld 408576698