Issue 10830075: Merge 144536 - Fix overlay display in certificate options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830075: Merge 144536 - Fix overlay display in certificate options. (Closed)

Created:
8 years, 4 months ago by Greg Spencer (Chromium)

Modified:
8 years, 4 months ago

Reviewers:
rkc

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/branches/1180/src/

Visibility:
Public.

Merge 144536 - Fix overlay display in certificate options. When we try to delete a certificate, the overlay that is shown doesn't have a parent set; which causes an exception in the show overlay javascipt. Fix this so the delete button works again. R=csilv@chromium.org BUG=130396 TEST=Tested that a certificate was deleted when the delete button was pressed and the OK option selected. Review URL: https://chromiumcodereview.appspot.com/10680010 TBR=rkc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149046

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/resources/options2/options_page.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

rkc1

8 years, 4 months ago (2012-07-30 22:19:58 UTC) #2

On 2012/07/30 22:10:13, Greg Spencer (Chromium) wrote:

LGTM, thanks for merging this!