Issue 10830066: Non-functional cleanup in ContentViewCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830066: Non-functional cleanup in ContentViewCore (Closed)

Created:
8 years, 4 months ago by Steve Block

Modified:
8 years, 4 months ago

Reviewers:
joth, Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Non-functional cleanup in ContentViewCore - Remove mentions of WebView - Remove @hide - Remove superfluous pure virtual method from ContentViewCore - Fix ordering of methods Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149165

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -59 lines)			Patch
M	content/browser/android/content_view_core_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	2 chunks	+19 lines, -23 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	8 chunks	+25 lines, -29 lines	0 comments	Download
M	content/public/browser/android/content_view_core.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói

8 years, 4 months ago (2012-07-31 10:51:10 UTC) #4

LGTM for content/public, but you will need someone from content/OWNERS (e.g.
avi@ or jam@) to approve the content/browser changes.

Expand Messages | Collapse Messages