Issue 10830055: adding overlay play button resource for media control on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830055: adding overlay play button resource for media control on android (Closed)

Created:
8 years, 4 months ago by qinmin

Modified:
8 years, 4 months ago

Reviewers:
tony, darin (slow to review)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

adding overlay play button resource for media control on android WebKit change: https://bugs.webkit.org/show_bug.cgi?id=92132 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148796

Patch Set 1 #

Patch Set 2 : adding the png file #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
A +	webkit/glue/resources/mediaplayer_overlay_play.png	View	1	Binary file		0 comments	Download
M	webkit/glue/webkit_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitplatformsupport_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/10830055/2001

8 years, 4 months ago (2012-07-27 20:32:49 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-07-27 20:32:51 UTC) #4

Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 404: Not Found

Expand Messages | Collapse Messages