Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 10830053: [chromeos] Simplify chromeos device policy tests (Closed)

Created:
8 years, 4 months ago by Nirnimesh
Modified:
8 years, 4 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, dyu1, Nirnimesh, anantha, oshima+watch_chromium.org, dennis_jeffrey, stevenjb+watch_chromium.org
Visibility:
Public.

Description

[chromeos] Simplify chromeos device policy tests - Remove the hacks that were there to accommodate /root/.forget_usernames - Make setUp() re-entrant. This is so that errors in a test's setup does not affect the next test. (DNS server and auth server start at a fixed port, so failure to clean them up would affect the next test) - Work around crbug.com/139166 BUG=139166 TEST=chromeos_device_policy.py R=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149012

Patch Set 1 #

Patch Set 2 : remove setup #

Patch Set 3 : . #

Patch Set 4 : relogin hack #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -138 lines) Patch
M chrome/test/functional/chromeos_device_policy.py View 1 2 3 7 chunks +23 lines, -68 lines 2 comments Download
M chrome/test/pyautolib/chromeos/suid_actions.py View 2 chunks +1 line, -36 lines 1 comment Download
M chrome/test/pyautolib/policy_base.py View 4 chunks +17 lines, -4 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 chunks +4 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nirnimesh
This CL fixes the large scale errors with enterprise tests. A test's error or failure ...
8 years, 4 months ago (2012-07-27 19:26:35 UTC) #1
bartfab (slow)
8 years, 4 months ago (2012-07-30 08:59:44 UTC) #2
LGTM with nits. Great work - I hope this will make our policy tests a lot more
reliable.

http://codereview.chromium.org/10830053/diff/6001/chrome/test/functional/chro...
File chrome/test/functional/chromeos_device_policy.py (right):

http://codereview.chromium.org/10830053/diff/6001/chrome/test/functional/chro...
chrome/test/functional/chromeos_device_policy.py:5: import logging
Nit: "logging" is no longer needed by this file

http://codereview.chromium.org/10830053/diff/6001/chrome/test/functional/chro...
chrome/test/functional/chromeos_device_policy.py:15: # owner.
Nit: This comment is actually no longer true. Now that the TestServer (mock
DMServer) is used, it decides who the owner is. And the owner is hard-coded in
that server as user@example.com.

http://codereview.chromium.org/10830053/diff/6001/chrome/test/pyautolib/chrom...
File chrome/test/pyautolib/chromeos/suid_actions.py (right):

http://codereview.chromium.org/10830053/diff/6001/chrome/test/pyautolib/chrom...
chrome/test/pyautolib/chromeos/suid_actions.py:15: import logging
Nit: "logging" is no longer needed by this file

Powered by Google App Engine
This is Rietveld 408576698