chrome/browser/resources/about_version.html - Issue 10830051: Restore <img> src values now that grit converts these.

Unified Diff: chrome/browser/resources/about_version.html

Issue 10830051: Restore <img> src values now that grit converts these. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ensure ThemeSource is loaded. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/about_version.html

diff --git a/chrome/browser/resources/about_version.html b/chrome/browser/resources/about_version.html

index 6f36f14e26c9d398fb66c4597175a9b3740e01f5..e0176555ca77e2a3a6bdf472b559cdfe682e7368 100644

--- a/chrome/browser/resources/about_version.html

+++ b/chrome/browser/resources/about_version.html

@@ -21,8 +21,13 @@ about:version template page

<body>

-

- <img id="logo-img">

+<if expr="pp_ifdef('android')">

+

+ <img src="../../app/theme/default_100_percent/%DISTRIBUTION%/product_logo.png">

flackr 2012/07/27 18:03:45 I'm not sure this is necessary (moved from about_v

Ted C 2012/07/27 18:18:45 Sadly it is, android excludes all the theme source

Dan Beam 2012/07/27 18:20:59 Is it possible to use ENABLE_THEMES instead of and

flackr 2012/07/27 18:24:24 I believe grit only knows what we pass it in grit_

flackr 2012/07/27 18:26:28 In fact I'll just pass enable_themes to grit as we

+</if>

+<if expr="not pp_ifdef('android')">

+ <img src="chrome://theme/IDR_PRODUCT_LOGO">

+</if>

</div>