(Views only) Prompt the user to reload the website after changing site permissions.

(Views only) Display an info bar that asks the user to reload the website, after changing site permissions.


BUG=113688
TEST=none
TBR=erg@chromium.org,rsesek@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149407

[markusheintz_, 2012-07-31 14:05:40]

Finnur since you have some experience with the old PageInfoBubble would you mind
reviewing this CL please? Thanks a lot.

[Finnur, 2012-08-01 08:23:58]

LGTM, with a couple of nits and one question.

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
File chrome/browser/ui/website_settings/website_settings.cc (right):

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
chrome/browser/ui/website_settings/website_settings.cc:102:
WebsiteSettings::~WebsiteSettings() {
This class is only alive while the UI is being shown, right?

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
File chrome/browser/ui/website_settings/website_settings.h (right):

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
chrome/browser/ui/website_settings/website_settings.h:148: // The flag that
controls whether an info bar is displayed after the website
s/info bar/infobar/

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
File chrome/browser/ui/website_settings/website_settings_infobar_delegate.h
(right):

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
chrome/browser/ui/website_settings/website_settings_infobar_delegate.h:20: //
Overwritten from ConfirmInfoBarDelegate:
nit: Overridden is probably the word you are looking for.

[markusheintz_, 2012-08-01 08:59:01]

Thanks a lot for the review! :)

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
File chrome/browser/ui/website_settings/website_settings.cc (right):

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
chrome/browser/ui/website_settings/website_settings.cc:102:
WebsiteSettings::~WebsiteSettings() {
On 2012/08/01 08:23:58, Finnur wrote:
> This class is only alive while the UI is being shown, right?
yes. It used to be the other way around.

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
File chrome/browser/ui/website_settings/website_settings.h (right):

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
chrome/browser/ui/website_settings/website_settings.h:148: // The flag that
controls whether an info bar is displayed after the website
On 2012/08/01 08:23:58, Finnur wrote:
> s/info bar/infobar/

Done.

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
File chrome/browser/ui/website_settings/website_settings_infobar_delegate.h
(right):

http://codereview.chromium.org/10830050/diff/10001/chrome/browser/ui/website_...
chrome/browser/ui/website_settings/website_settings_infobar_delegate.h:20: //
Overwritten from ConfirmInfoBarDelegate:
On 2012/08/01 08:23:58, Finnur wrote:
> nit: Overridden is probably the word you are looking for.

Done.

[markusheintz_, 2012-08-01 12:03:43]

TBR'ing OWNERs for trivial cocoa and gtk changes after LGTM

@erg,rsesek: please double check.

[commit-bot: I haz the power, 2012-08-01 12:03:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10830050/5005

[commit-bot: I haz the power, 2012-08-01 13:50:28]

Change committed as 149407