- Add the ability to protect VirtualMemory.

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/compiler_stats.h"
 #include "vm/flags.h"
@@ skipping 208 matching lines @@
     PrintSizes();
   }
 }
 
 
 void Heap::EnableGrowthControl() {
   old_space_->EnableGrowthControl();
 }
 
 
+void Heap::Protect(VirtualMemory::Protection mode) {
+  new_space_->Protect(mode);
+  old_space_->Protect(mode);
+  code_space_->Protect(mode);

[siva, 2012/07/27 01:55:00]

This seems weird here as we independently set the code pages to executable.
If somebody calls heap()->Protect(kReadWrite);
hoping to make the new space and old space non executable they would
inadvertently set the code pages also as non executable.

[Ivan Posva, 2012/07/27 18:02:56]

Done.

+}
+
+
 uword Heap::TopAddress() {
   return reinterpret_cast<uword>(new_space_->TopAddress());
 }
 
 
 uword Heap::EndAddress() {
   return reinterpret_cast<uword>(new_space_->EndAddress());
 }
 
 
@@ skipping 90 matching lines @@
   isolate()->IncrementNoGCScopeDepth();
 }
 
 
 NoGCScope::~NoGCScope() {
   isolate()->DecrementNoGCScopeDepth();
 }
 #endif  // defined(DEBUG)
 
 }  // namespace dart