Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 10830037: Use a differnt GUID to access the Windows core driver that contains XPS. (Closed)

Created:
8 years, 4 months ago by Albert Bodenhamer
Modified:
8 years, 4 months ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Use a differnt GUID to access the Windows core driver that contains XPS. The main Windows core printer driver has several different guids associated with it. Windows 8 removes all but 1 of these guids. This CL switches to use the guid that is still supported. AFAICT this should continue to work on all of the platforms we support. My testing is blocked at the moment due to a problem with internal software. BUG=139156 TEST=Try to install driver (all supported Windows versions) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Albert Bodenhamer
8 years, 4 months ago (2012-07-26 17:53:47 UTC) #1
Scott Byer
lgtm
8 years, 4 months ago (2012-07-26 18:38:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10830037/1
8 years, 4 months ago (2012-07-26 18:40:10 UTC) #3
commit-bot: I haz the power
Try job failure for 10830037-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-26 23:39:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10830037/1
8 years, 4 months ago (2012-07-26 23:43:46 UTC) #5
commit-bot: I haz the power
Try job failure for 10830037-1 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 4 months ago (2012-07-27 02:45:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10830037/1
8 years, 4 months ago (2012-07-27 16:29:20 UTC) #7
commit-bot: I haz the power
Try job failure for 10830037-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-27 19:17:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10830037/1
8 years, 4 months ago (2012-07-27 19:19:37 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 21:28:00 UTC) #10
Change committed as 148816

Powered by Google App Engine
This is Rietveld 408576698