Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10830036: Moved the AppNotification system into extensions namespace (Closed)

Created:
8 years, 4 months ago by Devlin
Modified:
8 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, estade+watch_chromium.org, tim (not reviewing)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149444

Patch Set 1 #

Patch Set 2 : Latest master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -38 lines) Patch
M chrome/browser/extensions/app_notification.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notification.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notification_browsertest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_notification_manager_sync_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_notification_storage.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notification_storage.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_notification_storage_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notification_test_util.h View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/app_notification_test_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_notify_channel_setup.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_notify_channel_setup.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_notify_channel_setup_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notify_channel_ui.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notify_channel_ui_android.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notify_channel_ui_android.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notify_channel_ui_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_notify_channel_ui_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/app_notification_data_type_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/app_notification_data_type_controller.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 6 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Devlin
Simple refactor; please review when time allows: sky - c/b/ui zea - c/b/sync mihaip - ...
8 years, 4 months ago (2012-07-31 22:54:54 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-07-31 22:58:55 UTC) #2
Nicolas Zea
sync LGTM
8 years, 4 months ago (2012-07-31 23:00:32 UTC) #3
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-07-31 23:01:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10830036/6003
8 years, 4 months ago (2012-08-01 16:42:38 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 18:06:55 UTC) #6 
Change committed as 149444

Powered by Google App Engine
This is Rietveld 408576698