Issue 10830035: Ignore block comments in JNI generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830035: Ignore block comments in JNI generator. (Closed)

Created:
8 years, 5 months ago by Iain Merrick

Modified:
8 years, 4 months ago

Reviewers:
bulach

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Ignore block comments in JNI generator. The JNI generator was being confused by the word 'native' appearing in a block comment in ChromeBrowserProvider.java. This patch ensures that all comments are stripped out correctly. BUG=138941 TEST=jni_generator_tests.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148967

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -5 lines)			Patch
	M	base/android/jni_generator/SampleForTests.java	View		1 chunk	+13 lines, -0 lines	0 comments	Download
	M	base/android/jni_generator/jni_generator.py	View		1 chunk	+16 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10830035/1

8 years, 4 months ago (2012-07-30 13:27:09 UTC) #3

commit-bot: I haz the power

Try job failure for 10830035-1 (retry) on win_rel for step "browser_tests". It's a second try, ...

8 years, 4 months ago (2012-07-30 15:35:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10830035/1

8 years, 4 months ago (2012-07-30 15:53:11 UTC) #5

Change committed as 148967

Expand Messages | Collapse Messages