Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 10830029: Makes maximized windows go in their own workspace regardless of (Closed)

Created:
8 years, 5 months ago by sky
Modified:
8 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Makes maximized windows go in their own workspace regardless of whether they are set to float across all workspaces. BUG=133577 TEST=covered by tests R=oshima@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M ash/wm/workspace/workspace_manager.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
8 years, 5 months ago (2012-07-26 00:45:24 UTC) #1
oshima
lgtm
8 years, 5 months ago (2012-07-26 13:53:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10830029/1
8 years, 4 months ago (2012-07-28 02:14:23 UTC) #3
commit-bot: I haz the power
Try job failure for 10830029-1 (retry) on linux_rel for steps "interactive_ui_tests, browser_tests". It's a second ...
8 years, 4 months ago (2012-07-28 11:18:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10830029/1
8 years, 4 months ago (2012-07-31 15:58:02 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 17:57:33 UTC) #6
Change committed as 149218

Powered by Google App Engine
This is Rietveld 408576698