Implement new slider control and disable the volume control when audio is muted.

Implement new slider control and disable the volume control when audio is muted.

Horizontal slider is implemented with image resources, and it changes UI based the on/off state.

Vertical slider is kept in the old way, since I don't have the UI resources for drawing the vertical slider. I wonder if I should remove the vertical slider bar supporting code, or leave it as it which is what I choose to do currently.


BUG=124097
TEST=Audio and brightness slider control should be in new UI, and audio slider bar should dim when muted.
TBR=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148778

[sadrul, 2012-07-26 00:05:45]

On 2012/07/25 23:55:55, jennyz wrote:

Keeping vertical sliders unchanged sounds good.

Question: when audio is muted, should the user be able to control the slider?

[jennyz, 2012-07-26 00:13:37]

On 2012/07/26 00:05:45, sadrul wrote:
> On 2012/07/25 23:55:55, jennyz wrote:
> 
> Keeping vertical sliders unchanged sounds good.
> 
> Question: when audio is muted, should the user be able to control the slider?

Yes, user is able to control the slider when the audio is muted(as soon as user
move the thumb button, it switch to "on" state), "disabled" is kind of
misleading, more accurately, it is an off state, with UI displayed with image
resources named as xxx_disabled.png.

[sadrul, 2012-07-26 18:10:40]

LGTM

http://codereview.chromium.org/10830027/diff/1/ui/views/controls/slider.h
File ui/views/controls/slider.h (right):

http://codereview.chromium.org/10830027/diff/1/ui/views/controls/slider.h#new...
ui/views/controls/slider.h:110: enum BorderElements {
Perhaps move the enum into the .cc file since it isn't used here.

[jennyz, 2012-07-27 16:51:57]

http://codereview.chromium.org/10830027/diff/1/ui/views/controls/slider.h
File ui/views/controls/slider.h (right):

http://codereview.chromium.org/10830027/diff/1/ui/views/controls/slider.h#new...
ui/views/controls/slider.h:110: enum BorderElements {
On 2012/07/26 18:10:40, sadrul wrote:
> Perhaps move the enum into the .cc file since it isn't used here.

Done.

[commit-bot: I haz the power, 2012-07-27 16:52:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10830027/4003

[commit-bot: I haz the power, 2012-07-27 16:52:17]

Presubmit check for 10830027-4003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    ui/resources

Presubmit checks took 1.1s to calculate.

[commit-bot: I haz the power, 2012-07-27 16:54:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10830027/4003