Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6766)

Unified Diff: chrome/browser/value_store/testing_value_store.cc

Issue 10830022: Fixed check return warnings from Coverity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed a nit: adding braces. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_loader_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/value_store/testing_value_store.cc
diff --git a/chrome/browser/value_store/testing_value_store.cc b/chrome/browser/value_store/testing_value_store.cc
index f5dbcb116ce9e40d3b593106b59cc313e8dd5da7..c079df5e5facc275aec6181c48fed0ee301f726e 100644
--- a/chrome/browser/value_store/testing_value_store.cc
+++ b/chrome/browser/value_store/testing_value_store.cc
@@ -98,8 +98,8 @@ ValueStore::WriteResult TestingValueStore::Set(
scoped_ptr<ValueStoreChangeList> changes(new ValueStoreChangeList());
for (DictionaryValue::Iterator it(settings); it.HasNext(); it.Advance()) {
Value* old_value = NULL;
- storage_.GetWithoutPathExpansion(it.key(), &old_value);
- if (!old_value || !old_value->Equals(&it.value())) {
+ if (!storage_.GetWithoutPathExpansion(it.key(), &old_value) ||
+ !old_value->Equals(&it.value())) {
changes->push_back(
ValueStoreChange(
it.key(),
« no previous file with comments | « chrome/browser/policy/policy_loader_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698