Issue 10830016: Replace PluginMessageLoopProxy with PluginThreadTaskRunner.

Issue 10830016: Replace PluginMessageLoopProxy with PluginThreadTaskRunner. (Closed)

Created:
8 years, 5 months ago by Sergey Ulanov

Modified:
8 years, 4 months ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace PluginMessageLoopProxy with PluginThreadTaskRunner. Previosly plugin code was using PluginMessageLoopProxy that implements MessageLoopProxy interface. We no longer need MessageLoopProxy. Replacing PluginMessageLoopProxy with PluginThreadTaskRunner that implements SingleThreadTaskRunner interface Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148801

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -183 lines)			Patch
D	remoting/base/plugin_message_loop_proxy.h	View		1 chunk	+0 lines, -64 lines	0 comments	Download
D	remoting/base/plugin_message_loop_proxy.cc	View		1 chunk	+0 lines, -70 lines	0 comments	Download
A +	remoting/base/plugin_thread_task_runner.h	View	1	4 chunks	+10 lines, -10 lines	0 comments	Download
A +	remoting/base/plugin_thread_task_runner.cc	View		5 chunks	+11 lines, -11 lines	0 comments	Download
M	remoting/client/plugin/chromoting_instance.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View		12 chunks	+15 lines, -15 lines	0 comments	Download
M	remoting/client/plugin/pepper_plugin_thread_delegate.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/plugin/host_plugin.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/host/plugin/host_script_object.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/host/plugin/host_script_object.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/remoting.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

lgtm http://codereview.chromium.org/10830016/diff/1/remoting/base/plugin_thread_task_runner.h File remoting/base/plugin_thread_task_runner.h (right): http://codereview.chromium.org/10830016/diff/1/remoting/base/plugin_thread_task_runner.h#newcode33 remoting/base/plugin_thread_task_runner.h:33: // base::MessageLoopProxy implementation. nit: base::SingleThreadTaskRunner implementation.

8 years, 4 months ago (2012-07-27 15:40:04 UTC) #3

Sergey Ulanov

http://codereview.chromium.org/10830016/diff/1/remoting/base/plugin_thread_task_runner.h File remoting/base/plugin_thread_task_runner.h (right): http://codereview.chromium.org/10830016/diff/1/remoting/base/plugin_thread_task_runner.h#newcode33 remoting/base/plugin_thread_task_runner.h:33: // base::MessageLoopProxy implementation. On 2012/07/27 15:40:04, alexeypa wrote: > ...

8 years, 4 months ago (2012-07-27 18:55:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10830016/5001

8 years, 4 months ago (2012-07-27 18:57:28 UTC) #5

Change committed as 148801

Expand Messages | Collapse Messages